[libc] Fix statfs_to_statvfs conversion function on rv32 #98098
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes implicit conversion loses integer precision warnings by adding explicit casts. Should be NFC for 64-bit systems.
|
@llvm/pr-subscribers-libc Author: Mikhail R. Gadelha (mikhailramalho) ChangesThis patch fixes implicit conversion loses integer precision warnings by adding explicit casts. Should be NFC for 64-bit systems. Full diff: https://github.com/llvm/llvm-project/pull/98098.diff 1 Files Affected:
diff --git a/libc/src/sys/statvfs/linux/statfs_utils.h b/libc/src/sys/statvfs/linux/statfs_utils.h
index 606786a571838..52f810d702d2a 100644
--- a/libc/src/sys/statvfs/linux/statfs_utils.h
+++ b/libc/src/sys/statvfs/linux/statfs_utils.h
@@ -77,14 +77,15 @@ LIBC_INLINE struct statvfs statfs_to_statvfs(const LinuxStatFs &in) {
struct statvfs out;
out.f_bsize = in.f_bsize;
out.f_frsize = in.f_frsize;
- out.f_blocks = in.f_blocks;
- out.f_bfree = in.f_bfree;
- out.f_bavail = in.f_bavail;
- out.f_files = in.f_files;
- out.f_ffree = in.f_ffree;
- out.f_favail = in.f_ffree;
- out.f_fsid = in.f_fsid.val[0] |
- static_cast<decltype(out.f_fsid)>(in.f_fsid.val[1]) << 32;
+ out.f_blocks = static_cast<decltype(out.f_blocks)>(in.f_blocks);
+ out.f_bfree = static_cast<decltype(out.f_bfree)>(in.f_bfree);
+ out.f_bavail = static_cast<decltype(out.f_bavail)>(in.f_bavail);
+ out.f_files = static_cast<decltype(out.f_files)>(in.f_files);
+ out.f_ffree = static_cast<decltype(out.f_ffree)>(in.f_ffree);
+ out.f_favail = static_cast<decltype(out.f_favail)>(in.f_ffree);
+ out.f_fsid = in.f_fsid.val[0];
+ if constexpr (sizeof(decltype(out.f_fsid)) == sizeof(uint64_t))
+ out.f_fsid |= static_cast<decltype(out.f_fsid)>(in.f_fsid.val[1]) << 32;
out.f_flag = in.f_flags;
out.f_namemax = in.f_namelen;
return out;
|
lntue
approved these changes
Jul 8, 2024
SchrodingerZhu
approved these changes
Jul 9, 2024
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes implicit conversion loses integer precision warnings by adding explicit casts. Should be NFC for 64-bit systems.